Add --plugin-path support for new platform plugins in dev #33865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdover
added
Team:Core
|
Pinging @elastic/kibana-platform |
💔 Build Failed |
joshdover
force-pushed
the
np-plugin-path-arg
branch
from
ecb2614
to
e2ab6f4
Compare
joshdover
changed the title
joshdover
force-pushed
the
np-plugin-path-arg
branch
from
e2ab6f4
to
2a3bf15
Compare
💔 Build Failed |
joshdover
force-pushed
the
np-plugin-path-arg
branch
from
2a3bf15
to
b6469fd
Compare
💔 Build Failed |
joshdover
force-pushed
the
np-plugin-path-arg
branch
2 times, most recently
from
42fc671
to
70e2ebc
Compare
💔 Build Failed |
|
retest |
💔 Build Failed |
joshdover
force-pushed
the
np-plugin-path-arg
branch
from
70e2ebc
to
ff33a90
Compare
💔 Build Failed |
joshdover
force-pushed
the
np-plugin-path-arg
branch
from
ff33a90
to
1d51d1e
Compare
💚 Build Succeeded |
joshdover
added
v8.0.0
release_note:skip
joshdover
changed the title
joshdover
force-pushed
the
np-plugin-path-arg
branch
from
1d51d1e
to
631d9ec
Compare
💚 Build Succeeded |
azasypkin
reviewed
Mar 28, 2019
azasypkin
reviewed
Mar 28, 2019
azasypkin
reviewed
Mar 28, 2019
joshdover
force-pushed
the
np-plugin-path-arg
branch
from
a1f8fb7
to
0ce12c5
Compare
💔 Build Failed |
|
retest |
💚 Build Succeeded |
azasypkin
approved these changes
Mar 29, 2019
I expect this to change pretty soon between #32722 and our plan to move |
💔 Build Failed |
|
retest |
💔 Build Failed |
💚 Build Succeeded |
joshdover
added a commit
that referenced
this pull request
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I'd like to be able to add test plugins that can be tested end-to-end using our functional test runner. We have a config for this under
test/plugin_functional/config.jsthat uses the--plugin-pathCLI arg for each plugin that it loads. This PR adds support for that CLI arg to the new platform only when in development.@azasypkin mentioned that this has not been supported because we wanted plugin discovery to be using baked-in paths. I can see how that creates some needed constraints on the discovery problem to make that implementation simpler, however I think this specific option is still useful.
This option does not add a new directory to do full discovery on. Instead it only directly to a directory for a specific plugin, not a directory to do additional discovery in (like
--plugin-dirdoes now). @epixa are there any other known issues with allowing this option?Update: @epixa acknowledges he's fine with option only existing in dev environment. In production we don't want relative paths to break.